Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use jobserver if available #153

Merged
merged 1 commit into from
Oct 28, 2022
Merged

use jobserver if available #153

merged 1 commit into from
Oct 28, 2022

Conversation

BusyJay
Copy link
Contributor

@BusyJay BusyJay commented Jun 3, 2022

passing --parallel to cmake will execute make with -jN hence jobserver
is ignored.

Before the change, logs in stderr:

make: warning: -jN forced in submake: disabling jobserver mode.
make: warning: -jN forced in submake: disabling jobserver mode.

@BusyJay
use jobserver if available
f5122d4 
passing --parallel to cmake will execute make with `-jN` hence jobserver
is ignored.

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
thomcc
thomcc approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, interesting. This seems to line up with existing documentation, thanks.

@thomcc thomcc merged commit edc139b into rust-lang:master Oct 28, 2022
@BusyJay BusyJay deleted the use-jobserver branch October 28, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcc thomcc thomcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BusyJay @thomcc